New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix frozen confirmbox when keyboard shown #5452
Conversation
…doesn't consume event.
frontend/ui/uimanager.lua
Outdated
@@ -701,6 +701,12 @@ function UIManager:sendEvent(event) | |||
checked_widgets[widget] = true | |||
if widget.widget:handleEvent(event) then return end | |||
end | |||
if widget.widget.modal then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it could just be an or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be a or
indeed, but I don't mind the split because of the lengthy comments.
But that if
might be a elseif
. Dunno if a is_always_active
might also be a modal
, but calling twice handleEvent on a same widget, even if it returns false, might have some side effect (can't think of any right now, but logically, it could).
A or
would solve this issue too, so why not :)
…oreader#5574) This reverts commit 513fd80.
see #5415 #4034