Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loading bar thicker #5581

Merged
merged 4 commits into from
Nov 10, 2019
Merged

loading bar thicker #5581

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15e2ed4
loading bar thicker
yparitcher Nov 8, 2019
4ef975f
margin
yparitcher Nov 9, 2019
5381df6
standard
yparitcher Nov 10, 2019
c788bfb
standard
yparitcher Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/apps/reader/modules/readerrolling.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ local InputContainer = require("ui/widget/container/inputcontainer")
local MultiConfirmBox = require("ui/widget/multiconfirmbox")
local ProgressWidget = require("ui/widget/progresswidget")
local ReaderPanning = require("apps/reader/modules/readerpanning")
local Size = require("ui/size")
local TimeVal = require("ui/timeval")
local UIManager = require("ui/uimanager")
local bit = require("bit")
Expand Down Expand Up @@ -1030,9 +1031,9 @@ function ReaderRolling:showEngineProgress(percent)
-- Widget size and position: best to anchor it at top left,
-- so it does not override the footer or a bookmark dogear
local x = 0
local y = 0
local y = 3
yparitcher marked this conversation as resolved.
Show resolved Hide resolved
local w = Screen:getWidth() / 3
local h = Screen:scaleBySize(5)
local h = Size.line.progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally also applied to the other progressbar but not strictly necessary. :-)

if self.engine_progress_widget then
self.engine_progress_widget:setPercentage(percent)
else
Expand Down
1 change: 1 addition & 0 deletions frontend/ui/size.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ local Size = {
thin = Screen:scaleBySize(0.5),
medium = Screen:scaleBySize(1),
thick = Screen:scaleBySize(1.5),
progress = Screen:scaleBySize(7),
},
item = {
height_default = Screen:scaleBySize(30),
Expand Down