Print zsync2's output on screen #5824
Conversation
|
Obligatory screenshot ;). (From a manual run, hence the lack of InfoMessage).
|
|
Not an issue in busybox?
|
|
Not on Kobo, and not on Kindle 5.x at least. I'll double-check on legacy
Kindle just to be sure.
…On Fri, Feb 7, 2020, 09:28 Frans de Jonge ***@***.***> wrote:
Not an issue in busybox?
In platform/common/spinning_zsync line 4:
set -o pipefail
^------^ SC2039: In POSIX sh, set option pipefail is undefined.
For more information:
https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, set option
pipefail ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5824?email_source=notifications&email_token=AAA3KZQNTYD7B7IRVQGNE7TRBULTXA5CNFSM4KRF3E72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELCDZIA#issuecomment-583285920>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3KZVM37URHPICKICOIADRBULTXANCNFSM4KRF3E7Q>
.
|
|
Hmm, appeared in busybox 1.16.0 (2010-01-26), conditional on BASH_COMPAT... I smell a rat. I'll double-check if it behaves properly for real. If not, |
|
I'd expect it to anyway. We'll just have to try it. ^_^ |
|
Kobo: BusyBox v1.22.0.kobo (pipefail works) |
|
Kindle 2.5: BusyBox v1.7.2 (2011-01-13 18:01:58 PST) (ouch.)
Insert Wilhelm scream here |
|
Insane shell wizardry incoming! |
zsync2 *shouldn'*t actually be leaving those around, though, unless it's killed early.
Because scientifica doesn't ship with a CR glyph ;).
Pickup the required zsync2/FBInk updates (koreader/koreader-base#1038)
i.e., cleanup temporary files
There's no longer a kill involved ^^
* Also remove the temporary files when doing a full retry * Bump base Pickup the required zsync2/FBInk updates (koreader/koreader-base#1038) * Actually does what it says on the tin for Abort i.e., cleanup temporary files
Instead of the blind spinner we used to have.
This is a bit of a hack (on both sides), and it currently extends towards the middle of the screen, which means the tail end of it will probably get overwritten by the "Success/Failure" popup.
Can easily be tweaked later, I'd like to get it in as-is to try it for real first ;).
Requires koreader/koreader-base#1038
This change is