Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodev: Avoid catchsegv via -S, --no-catchsegv #7044

Merged
merged 4 commits into from Dec 24, 2020

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Dec 24, 2020

This works around #7036 on my end (so far).


This change is Reviewable

@NiLuJe NiLuJe requested a review from Frenzie as a code owner December 24, 2020 01:31
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a file?

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, already part of #6976

@Frenzie Frenzie added this to the 2021.01 milestone Dec 24, 2020
@Frenzie
Copy link
Member

Frenzie commented Dec 24, 2020

Before you merge this, have you tried the rather significantly simpler os.exit(ret, true)?

@Frenzie
Copy link
Member

Frenzie commented Dec 24, 2020

It's Lua 5.2, but it's been supported in LuaJIT for a decade LuaJIT/LuaJIT@7338456

@Frenzie
Copy link
Member

Frenzie commented Dec 24, 2020

And get rid of that fugly mess. >_>

@NiLuJe
Copy link
Member Author

NiLuJe commented Dec 24, 2020

@Frenzie: That is indeed much better, thanks ;).

@NiLuJe NiLuJe changed the title kodev: Avoid catchsegv when using --sane-return kodev: Avoid catchsegv via -S, --no-catchsegv Dec 24, 2020
@Frenzie
Copy link
Member

Frenzie commented Dec 24, 2020

Much nicer. ^_^

@NiLuJe NiLuJe merged commit 7bc8ed8 into koreader:master Dec 24, 2020
Frenzie added a commit to Frenzie/koreader that referenced this pull request Dec 25, 2020
Frenzie added a commit that referenced this pull request Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants