Minor followup to #7335 #7347
Merged
Minor followup to #7335 #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(e.g., hold + tap, "Go to page").
layout. Stuff that concerns the global/screen layout is redundant here, as Menus are re-initialized on screen geometry updates.
|
@poire-z: Your analysis of the (And, re-reading how it's used, I would agree with your assessment. Possibly a remnant from back when we didn't handle screen geometry updates sanely in the FM/FM-adjacent stuff?). |
poire-z
approved these changes
Feb 25, 2021
|
Minor issue in page numbers footer: |
|
What do you mean by "empty day"? |
|
No records for that day |
|
|
|
Oh, the day view, right :). |
NiLuJe
added a commit
that referenced
this pull request
Feb 26, 2021
) By disabling the pagination buttons, and showing a specific label, like Menu (#7347 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_recalculateDimen, as it should only be concerned with item layout ([RFC] Pagination UI shenanigans #7335 (comment))This change is