-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor followup to #7335 #7347
Minor followup to #7335 #7347
Conversation
(e.g., hold + tap, "Go to page").
layout. Stuff that concerns the global/screen layout is redundant here, as Menus are re-initialized on screen geometry updates.
@poire-z: Your analysis of the (And, re-reading how it's used, I would agree with your assessment. Possibly a remnant from back when we didn't handle screen geometry updates sanely in the FM/FM-adjacent stuff?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cleaner the better :)
Minor issue in page numbers footer: |
What do you mean by "empty day"? |
No records for that day |
Oh, the day view, right :). |
) By disabling the pagination buttons, and showing a specific label, like Menu (#7347 (comment))
_recalculateDimen
, as it should only be concerned with item layout ([RFC] Pagination UI shenanigans #7335 (comment))This change is