Calibre plugin - Series/Tag browser updated to show back button. #8869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a bug. Working on fixing it. |
- Moved "find books" option from CalibreSearch:find(option) into CalibreSearch:browse(option) function. This way all search options are handled in one place only. - Menu is created only once and it is in CalibreSearch:browse(option) function. This is where it is also invoked with UIManager:show(w). Switching between different menu content (tags/series/books) is done using CalibreSearch:switchResults function which will internally call Menu:switchItemTable. Previously menu was being instantiated in 2 places depending on are we searching books or series/tags - Return arrow navigation: Border around Menu is gone to give space for back arrow. Navigation seems to be working fine so far but will give it some time to test in case I find any other bugs
|
Seems to be working as I expect it. Tested using emulator and Libra H20. |
pazos
approved these changes
Mar 15, 2022
Frenzie
requested changes
Mar 16, 2022
There was a problem hiding this comment.
Could you fix these issues?
plugins/calibre.koplugin/search.lua:6:7: unused variable 'CenterContainer'
plugins/calibre.koplugin/search.lua:17:7: unused variable 'Size'
plugins/calibre.koplugin/search.lua:384:1: line contains only whitespace
plugins/calibre.koplugin/search.lua:459:1: line contains only whitespace
|
@Frenzie Done. QQ: What do you execute to get those warnings? I was just running it with |
|
In this case I just saw a red cross on the CircleCI build. If you run |
|
I had to install luacheck but yeah I see it now. Good to know going forward. |
Frenzie
approved these changes
Mar 16, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing tags and series there was no way to go "back" from tag/series results. Figured we can enable return button navigation by pushing entry to paths property of Menu widget.
When return button is enabled it is overlapping with rounded border previously present on browse widget so I made it borderless.
This change is