Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Animator to start automatically by default, without waiting for the next frame, and allowing to configure that behaviour in root and children nodes #1100

Merged
merged 2 commits into from Nov 10, 2022

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Nov 10, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 53.31% // Head: 53.31% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (943ca5a) compared to base (5943042).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   53.31%   53.31%           
=======================================
  Files        1851     1851           
  Lines      120545   120560   +15     
  Branches    18778    18779    +1     
=======================================
+ Hits        64264    64279   +15     
+ Misses      50985    50980    -5     
- Partials     5296     5301    +5     
Flag Coverage Δ
unittests 53.31% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onMain/kotlin/com/soywiz/korge/animate/Animator.kt 62.13% <71.87%> (+1.22%) ⬆️
...kotlin/com/soywiz/korge/animate/NewAnimatorTest.kt 99.08% <95.65%> (-0.92%) ⬇️
...monTest/kotlin/com/soywiz/korim/format/EXIFTest.kt 75.00% <0.00%> (-25.00%) ⬇️
...tlin/com/soywiz/korio/net/AsyncClientServerTest.kt 76.92% <0.00%> (-7.70%) ⬇️
...est/kotlin/com/soywiz/korge/atlas/AtlasInfoTest.kt 66.19% <0.00%> (-4.23%) ⬇️
...commonTest/kotlin/com/soywiz/korim/font/TTfTest.kt 92.30% <0.00%> (-3.85%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 82.14% <0.00%> (-3.58%) ⬇️
...ommonTest/kotlin/com/soywiz/korge3d/ColladaTest.kt 89.18% <0.00%> (-2.71%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/WAV.kt 85.58% <0.00%> (-1.81%) ⬇️
...mmonTest/kotlin/com/soywiz/korim/format/QOITest.kt 94.73% <0.00%> (-1.76%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 6c07564 into main Nov 10, 2022
@soywiz soywiz deleted the feature/animator.start.automatically branch October 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants