Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ISO8601 parsing with offsets #1104

Merged
merged 1 commit into from Nov 10, 2022
Merged

Fixes ISO8601 parsing with offsets #1104

merged 1 commit into from Nov 10, 2022

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Nov 10, 2022

Fixes #1025

@soywiz soywiz changed the title Fixes ISO8601 parsing Fixes ISO8601 parsing with offsets Nov 10, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 53.31% // Head: 53.36% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (005e045) compared to base (5943042).
Patch coverage: 94.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   53.31%   53.36%   +0.05%     
==========================================
  Files        1851     1856       +5     
  Lines      120545   120738     +193     
  Branches    18778    18802      +24     
==========================================
+ Hits        64264    64432     +168     
- Misses      50985    50998      +13     
- Partials     5296     5308      +12     
Flag Coverage Δ
unittests 53.36% <94.44%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/commonMain/kotlin/com/soywiz/klock/DateTimeTz.kt 49.01% <ø> (ø)
.../src/commonMain/kotlin/com/soywiz/klock/ISO8601.kt 75.74% <90.00%> (+0.23%) ⬆️
...mmonMain/kotlin/com/soywiz/klock/TimezoneOffset.kt 89.47% <100.00%> (+0.58%) ⬆️
.../commonTest/kotlin/com/soywiz/klock/ISO8601Test.kt 100.00% <100.00%> (ø)
...st/kotlin/com/soywiz/korge/view/ktree/KTreeTest.kt 85.71% <0.00%> (-14.29%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/IsoVfsTest.kt 77.77% <0.00%> (-11.12%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/ResourcesVfsTest.kt 90.90% <0.00%> (-9.10%) ⬇️
...n/com/soywiz/korge/atlas/AtlasResourceProcessor.kt 77.77% <0.00%> (-5.56%) ⬇️
...commonTest/kotlin/com/soywiz/korim/font/TTfTest.kt 92.30% <0.00%> (-3.85%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 82.14% <0.00%> (-3.58%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit f91b3ea into main Nov 10, 2022
@soywiz soywiz deleted the fix/fix.ISO8601.parsing branch October 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone parsing with ISO8601 not working
2 participants