Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start work removing KorUI by starting dropping the KorgeDebugNode interface and moving KorUI to the JVM only KorGE target #1114

Merged
merged 3 commits into from Nov 16, 2022

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Nov 16, 2022

and going reflective with annotations on the JVM only, since that's the only platform with the debugger. Eventually other platforms could be supported with a compiler plugin somehow. For now, let's focus the debugger on the JVM

…erface and going reflective with annotations on the JVM only, since that's the only platform with the debugger. Eventually other platforms could be supported with a compiler plugin somehow. For now, let's focus the debugger on the JVM
@codecov-commenter
Copy link

Codecov Report

Base: 53.55% // Head: 53.39% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (066660a) compared to base (0ab17ab).
Patch coverage: 14.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   53.55%   53.39%   -0.17%     
==========================================
  Files        1877     1876       -1     
  Lines      122426   122499      +73     
  Branches    19030    19058      +28     
==========================================
- Hits        65570    65409     -161     
- Misses      51473    51718     +245     
+ Partials     5383     5372      -11     
Flag Coverage Δ
unittests 53.39% <14.21%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/commonMain/kotlin/com/soywiz/kds/ArrayListExt.kt 35.48% <0.00%> (-2.89%) ⬇️
...ge-sandbox/src/commonMain/kotlin/samples/MainUI.kt 0.00% <0.00%> (ø)
...lin/com/soywiz/korge/debug/ToUiEditableValueExt.kt 0.00% <ø> (ø)
...n/com/soywiz/korge/debug/UiTwoItemEditableValue.kt 0.00% <0.00%> (ø)
.../commonMain/kotlin/com/soywiz/korge/ui/UIButton.kt 43.83% <ø> (+1.16%) ⬆️
...onMain/kotlin/com/soywiz/korge/ui/UIProgressBar.kt 44.00% <ø> (+6.06%) ⬆️
...mmonMain/kotlin/com/soywiz/korge/view/BlendMode.kt 60.93% <0.00%> (-0.97%) ⬇️
...commonMain/kotlin/com/soywiz/korge/view/Ellipse.kt 38.88% <0.00%> (+1.05%) ⬆️
...c/commonMain/kotlin/com/soywiz/korge/view/Stage.kt 70.00% <0.00%> (+4.37%) ⬆️
...rc/commonMain/kotlin/com/soywiz/korge/view/Text.kt 51.62% <ø> (+0.82%) ⬆️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…olate it for future removal, now all the places use @ViewProperty instead of KorgeDebugNode.buildDebugComponent...
@soywiz soywiz changed the title Start work removing KorUI by starting dropping the KorgeDebugNode interface Start work removing KorUI by starting dropping the KorgeDebugNode interface and moving KorUI to the JVM only KorGE target Nov 16, 2022
@soywiz soywiz merged commit 2d6187c into main Nov 16, 2022
@soywiz soywiz deleted the feature/removing.korui.by.simplifying.debug.nodes branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants