Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reference tests with screenshot tests and do some fixes and improvements #1320

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 12, 2023

No description provided.

@soywiz soywiz force-pushed the fix/replace.text.reference.tests.with.screenshot.tests.and.some.fixes branch from 0ebef8a to 36c2546 Compare February 12, 2023 21:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 52.73% // Head: 51.93% // Decreases project coverage by -0.81% ⚠️

Coverage data is based on head (df64119) compared to base (ed46111).
Patch coverage: 21.19% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   52.73%   51.93%   -0.81%     
==========================================
  Files        1690     1690              
  Lines      103449   103537      +88     
  Branches    15301    15304       +3     
==========================================
- Hits        54555    53772     -783     
- Misses      44541    45465     +924     
+ Partials     4353     4300      -53     
Flag Coverage Δ
unittests 51.93% <21.19%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/com/soywiz/korlibs/root/RootKorlibsPlugin.kt 0.00% <0.00%> (ø)
...nTest/kotlin/com/soywiz/korge/KorgeHeadlessTest.kt 82.14% <ø> (-0.62%) ⬇️
.../kotlin/com/soywiz/korge/testing/BitmapAsserter.kt 0.00% <0.00%> (ø)
korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt 39.56% <0.00%> (-5.27%) ⬇️
...w/src/commonMain/kotlin/com/soywiz/korev/Events.kt 61.25% <0.00%> (-0.18%) ⬇️
...c/commonMain/kotlin/com/soywiz/korgw/GameWindow.kt 37.38% <0.00%> (+0.41%) ⬆️
...mMain/kotlin/com/soywiz/kgl/KmlGlContextDefault.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korgw/osx/MacosGLContext.kt 0.00% <0.00%> (ø)
...ain/kotlin/com/soywiz/korgw/osx/MacosGameWindow.kt 0.00% <0.00%> (ø)
...monMain/kotlin/com/soywiz/korim/bitmap/Bitmap32.kt 55.58% <22.22%> (-3.47%) ⬇️
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 82f56dd into main Feb 12, 2023
@soywiz soywiz deleted the fix/replace.text.reference.tests.with.screenshot.tests.and.some.fixes branch October 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants