Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start making value and mutable korma APIs + join basic extension methods into korma classes #1340

Merged
merged 3 commits into from Feb 15, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 15, 2023

This should allow going ahead with the release, while preparing for MFVC when they are ready.

Some work on #1257

We will need to be sure that APIs that return mutable types are renamed and hopefully marked as such. ie. fun View.getWindowBounds should be renamed to fun View.getMWindowBounds to be prepared

@codecov-commenter
Copy link

Codecov Report

Base: 51.97% // Head: 51.93% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (129ed84) compared to base (8ccccf8).
Patch coverage: 57.89% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   51.97%   51.93%   -0.05%     
==========================================
  Files        1687     1687              
  Lines      103935   103940       +5     
  Branches    15323    15324       +1     
==========================================
- Hits        54023    53982      -41     
- Misses      45636    45674      +38     
- Partials     4276     4284       +8     
Flag Coverage Δ
unittests 51.93% <57.89%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/commonMain/kotlin/samples/MainTrimmedAtlas.kt 0.00% <0.00%> (ø)
...c/commonMain/kotlin/com/soywiz/korge/ui/UIImage.kt 0.00% <0.00%> (ø)
.../commonMain/kotlin/com/soywiz/korge/ui/UIWindow.kt 0.00% <0.00%> (ø)
.../commonMain/kotlin/com/soywiz/korge/view/Camera.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korge/view/camera/Camera.kt 0.00% <0.00%> (ø)
...n/kotlin/com/soywiz/korge/view/camera/CameraOld.kt 0.00% <0.00%> (ø)
...mmonMain/kotlin/com/soywiz/korge/view/grid/Grid.kt 8.33% <0.00%> (ø)
...Main/kotlin/com/soywiz/korge/view/tiles/TileMap.kt 65.23% <0.00%> (ø)
...otlin/com/soywiz/korge/view/vector/GpuShapeView.kt 17.33% <ø> (ø)
...orge/src/jvmMain/kotlin/com/soywiz/korge/awt/UI.kt 0.00% <0.00%> (ø)
... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz changed the title Start making value and mutable korma APIs Start making value and mutable korma APIs + join basic extension methods into korma classes Feb 15, 2023
@soywiz soywiz merged commit c9cc1a7 into main Feb 15, 2023
@soywiz soywiz deleted the feature/wip.mark.value.and.mutable.apis branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants