Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task dependency issue #1345. #1348

Merged
merged 6 commits into from Feb 21, 2023
Merged

Fix task dependency issue #1345. #1348

merged 6 commits into from Feb 21, 2023

Conversation

Kietyo
Copy link
Contributor

@Kietyo Kietyo commented Feb 19, 2023

Fixes #1345

@codecov-commenter
Copy link

Codecov Report

Base: 51.80% // Head: 51.80% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b6617a3) compared to base (f01fb62).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
- Coverage   51.80%   51.80%   -0.01%     
==========================================
  Files        1686     1686              
  Lines      104269   104269              
  Branches    15358    15358              
==========================================
- Hits        54016    54014       -2     
- Misses      45973    45978       +5     
+ Partials     4280     4277       -3     
Flag Coverage Δ
unittests 51.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/src/commonMain/kotlin/com/soywiz/klock/Sleep.kt 0.00% <0.00%> (-50.00%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/MountableVfsTest.kt 62.50% <0.00%> (-18.75%) ⬇️
...com/soywiz/korim/text/RichTextDataPlacementTest.kt 78.57% <0.00%> (-14.29%) ⬇️
...mmonTest/kotlin/com/soywiz/korim/format/DDSTest.kt 85.00% <0.00%> (-5.00%) ⬇️
.../kotlin/com/soywiz/korau/format/AudioFormatTest.kt 96.15% <0.00%> (-3.85%) ⬇️
...lin/com.soywiz.korau.sound/SoundAudioStreamTest.kt 82.75% <0.00%> (-3.45%) ⬇️
...ommonMain/kotlin/com/soywiz/klock/hr/HRTimeSpan.kt 24.32% <0.00%> (-2.71%) ⬇️
...mmonTest/kotlin/com/soywiz/korim/format/ASETest.kt 96.53% <0.00%> (-1.16%) ⬇️
...c/commonMain/kotlin/com/soywiz/korgw/GameWindow.kt 37.56% <0.00%> (-0.56%) ⬇️
...tlin/com/soywiz/korio/net/AsyncClientServerTest.kt 80.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz
Copy link
Member

soywiz commented Feb 20, 2023

Tests are not passing, so it cannot be merged. Do you know why is it failing?

@Kietyo
Copy link
Contributor Author

Kietyo commented Feb 21, 2023

Managed to fix tests

@soywiz soywiz merged commit a1489a1 into korlibs:main Feb 21, 2023
@soywiz
Copy link
Member

soywiz commented Feb 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants