Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify gamepad mapping #1350

Merged
merged 9 commits into from Feb 20, 2023
Merged

Simplify gamepad mapping #1350

merged 9 commits into from Feb 20, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Feb 19, 2023

Some work simplifying #1347

@soywiz soywiz marked this pull request as ready for review February 19, 2023 18:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Base: 51.78% // Head: 51.78% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2173cf5) compared to base (575a5df).
Patch coverage: 2.08% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
- Coverage   51.78%   51.78%   -0.01%     
==========================================
  Files        1685     1685              
  Lines      104219   104186      -33     
  Branches    15349    15340       -9     
==========================================
- Hits        53974    53948      -26     
- Misses      45947    45951       +4     
+ Partials     4298     4287      -11     
Flag Coverage Δ
unittests 51.78% <2.08%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...idMain/kotlin/com/soywiz/korgw/KorgwSurfaceView.kt 0.00% <0.00%> (ø)
...w/src/commonMain/kotlin/com/soywiz/korev/Events.kt 61.25% <0.00%> (ø)
...mmonMain/kotlin/com/soywiz/korev/gamepad/XInput.kt 0.00% <0.00%> (ø)
...c/commonMain/kotlin/com/soywiz/korgw/GameWindow.kt 37.87% <0.00%> (+0.30%) ⬆️
...c/commonMain/kotlin/com/soywiz/korgw/x11/X11Joy.kt 0.00% <0.00%> (ø)
...kotlin/com/soywiz/korgw/osx/MacosGameController.kt 0.00% <0.00%> (ø)
...rc/jvmMain/kotlin/com/soywiz/korgw/win32/XInput.kt 0.00% <0.00%> (ø)
...gw/src/commonMain/kotlin/com/soywiz/korev/Input.kt 59.44% <8.82%> (+3.34%) ⬆️
...idMain/kotlin/com/soywiz/klogger/ConsoleAndroid.kt 0.00% <0.00%> (-23.81%) ⬇️
...st/kotlin/com/soywiz/korge/view/ktree/KTreeTest.kt 85.71% <0.00%> (-14.29%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 931269d into main Feb 20, 2023
@soywiz soywiz deleted the cleanup/simplify.gamepad.mapping branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants