Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added replace filter (#955) #1386

Merged
merged 1 commit into from Mar 4, 2023
Merged

Added replace filter (#955) #1386

merged 1 commit into from Mar 4, 2023

Conversation

SoftMachina
Copy link
Contributor

I hope this is ok, I haven't contributed to anything before.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.03 ⚠️

Comparison is base (b9ff3f9) 51.97% compared to head (73c4c1c) 51.95%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1386      +/-   ##
==========================================
- Coverage   51.97%   51.95%   -0.03%     
==========================================
  Files        1637     1637              
  Lines       99960    99962       +2     
  Branches    14611    14612       +1     
==========================================
- Hits        51955    51935      -20     
- Misses      43899    43923      +24     
+ Partials     4106     4104       -2     
Flag Coverage Δ
unittests 51.95% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...commonTest/kotlin/com/soywiz/korte/TemplateTest.kt 47.71% <0.00%> (-0.17%) ⬇️
...mmonMain/kotlin/com/soywiz/korte/DefaultFilters.kt 56.86% <100.00%> (+0.42%) ⬆️
...idMain/kotlin/com/soywiz/klogger/ConsoleAndroid.kt 0.00% <0.00%> (-23.81%) ⬇️
...rc/commonMain/kotlin/com/soywiz/klogger/Console.kt 29.62% <0.00%> (-12.35%) ⬇️
...st/kotlin/com/soywiz/korio/vfs/MountableVfsTest.kt 71.87% <0.00%> (-6.25%) ⬇️
...commonTest/kotlin/com/soywiz/korim/font/TTfTest.kt 88.88% <0.00%> (-4.45%) ⬇️
...src/commonMain/kotlin/com/soywiz/klogger/Logger.kt 47.27% <0.00%> (-3.64%) ⬇️
...mmonTest/kotlin/com/soywiz/korio/vfs/ZipVfsTest.kt 85.55% <0.00%> (-3.34%) ⬇️
...tlin/com/soywiz/korio/net/AsyncClientServerTest.kt 80.00% <0.00%> (-2.50%) ⬇️
...ain/kotlin/com/soywiz/korim/format/ImageFormats.kt 24.39% <0.00%> (-2.44%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 0fbe3fd into korlibs:main Mar 4, 2023
@soywiz
Copy link
Member

soywiz commented Mar 4, 2023

It is perfectly fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants