Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes metal shader test, simplify metal shader generation and testing and move to common to run tests on JVM that is faster and support assertEquals string comparison #1390

Merged
merged 2 commits into from Mar 7, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 7, 2023

/cc @ygdrasil-io

I have simplified it so we can run in the JVM. In the junit assertEquals output the JVM intellij supports shpwing diffs which is convenient:

Screenshot 2023-03-07 at 10 32 15

I have split the arguments into separate lines, so it is reasonable to compare them as a whole as a string that is easier to review and update

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.03 ⚠️

Comparison is base (23c9020) 51.95% compared to head (e9b1ee0) 51.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   51.95%   51.93%   -0.03%     
==========================================
  Files        1641     1646       +5     
  Lines      100042   100258     +216     
  Branches    14618    14646      +28     
==========================================
+ Hits        51975    52067      +92     
- Misses      43961    44061     +100     
- Partials     4106     4130      +24     
Flag Coverage Δ
unittests 51.93% <77.77%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...wiz/korag/metal/shader/BaseMetalShaderGenerator.kt 11.76% <ø> (ø)
...wiz/korag/metal/shader/MetalShaderBodyGenerator.kt 30.64% <ø> (ø)
...ain/kotlin/com/soywiz/korag/metal/shader/Shader.kt 100.00% <ø> (ø)
...monMain/kotlin/com.soywiz.ktruth/BooleanSubject.kt 0.00% <0.00%> (ø)
...Main/kotlin/com.soywiz.ktruth/CollectionSubject.kt 11.11% <20.00%> (+11.11%) ⬆️
.../commonMain/kotlin/com.soywiz.ktruth/AnySubject.kt 33.33% <40.00%> (+33.33%) ⬆️
.../soywiz/korag/metal/shader/MetalShaderGenerator.kt 83.50% <100.00%> (ø)
...wiz/korag/metal/shader/MetalShaderGeneratorTest.kt 100.00% <100.00%> (ø)
...ck/src/commonMain/kotlin/com/soywiz/klock/Sleep.kt 0.00% <0.00%> (-50.00%) ⬇️
...idMain/kotlin/com/soywiz/klogger/ConsoleAndroid.kt 0.00% <0.00%> (-23.81%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz changed the title Simplify metal shader generation and testing and move to common to run tests on JVM that is faster and support assertEquals string comparison Fixes metal shader test, simplify metal shader generation and testing and move to common to run tests on JVM that is faster and support assertEquals string comparison Mar 7, 2023
@soywiz soywiz merged commit f9574ca into main Mar 7, 2023
9 checks passed
@soywiz soywiz deleted the fix/fix.metal.test.simplify branch October 4, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants