Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate texture units & samplers from uniforms, and start deprecating AGUniformValues #1460

Merged
merged 12 commits into from Mar 24, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 23, 2023

No description provided.

@soywiz soywiz changed the title [WIP] Separate texture units from uniforms, and start deprecating AGUniformValues Separate texture units & samplers from uniforms, and start deprecating AGUniformValues Mar 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 62.26% and project coverage change: -0.04 ⚠️

Comparison is base (1ca9ef6) 51.62% compared to head (acc0ba5) 51.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   51.62%   51.59%   -0.04%     
==========================================
  Files        1677     1677              
  Lines       98875    98869       -6     
  Branches    13933    13933              
==========================================
- Hits        51044    51010      -34     
- Misses      43974    44004      +30     
+ Partials     3857     3855       -2     
Flag Coverage Δ
unittests 51.59% <62.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...otlin/com/soywiz/korge/render/LineRenderBatcher.kt 29.72% <0.00%> (+0.26%) ⬆️
...com/soywiz/korge/view/filter/ViewBackdropFilter.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korge/view/mask/ViewMask.kt 0.00% <0.00%> (ø)
...monMain/kotlin/com/soywiz/korag/AGTextureDrawer.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korge/view/fast/FSprites.kt 32.31% <8.33%> (-0.20%) ⬇️
...m/soywiz/korge/view/vector/GpuShapeViewCommands.kt 5.60% <25.00%> (+0.29%) ⬆️
...in/kotlin/com/soywiz/korge/render/RenderContext.kt 61.23% <26.66%> (+0.73%) ⬆️
korgw/src/commonMain/kotlin/com/soywiz/korag/AG.kt 38.70% <33.33%> (ø)
.../src/commonMain/kotlin/com/soywiz/korag/AGState.kt 54.10% <33.33%> (-0.87%) ⬇️
.../src/commonMain/kotlin/com/soywiz/korag/AGValue.kt 22.56% <50.00%> (-24.14%) ⬇️
... and 11 more

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 27e0789 into main Mar 24, 2023
8 of 9 checks passed
@soywiz soywiz deleted the cleanup/separate.uniform.from.textures branch October 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants