Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further mutable cleanups and MMatrix #1484

Merged
merged 8 commits into from Mar 29, 2023

Conversation

soywiz
Copy link
Member

@soywiz soywiz commented Mar 29, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage: 39.63% and project coverage change: -0.03 ⚠️

Comparison is base (cc53d85) 51.53% compared to head (9e03755) 51.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
- Coverage   51.53%   51.51%   -0.03%     
==========================================
  Files        1687     1689       +2     
  Lines       98725    98693      -32     
  Branches    13957    13953       -4     
==========================================
- Hits        50882    50838      -44     
- Misses      43963    43984      +21     
+ Partials     3880     3871       -9     
Flag Coverage Δ
unittests 51.51% <39.63%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/commonMain/kotlin/korlibs/datastructure/Keep.kt 0.00% <0.00%> (ø)
...box/src/commonMain/kotlin/samples/MainBunnymark.kt 0.00% <0.00%> (ø)
...ommonMain/kotlin/samples/MainGpuVectorRendering.kt 0.00% <0.00%> (ø)
...mmonMain/kotlin/samples/MainGpuVectorRendering3.kt 0.00% <0.00%> (ø)
...rc/commonMain/kotlin/samples/MainRotatedTexture.kt 0.00% <0.00%> (ø)
...-sandbox/src/commonMain/kotlin/samples/MainText.kt 0.00% <0.00%> (ø)
...ain/kotlin/korlibs/korge/render/RenderContext2D.kt 69.71% <ø> (+0.48%) ⬆️
...kotlin/korlibs/korge/render/TexturedVertexArray.kt 59.54% <0.00%> (+0.45%) ⬆️
...in/kotlin/korlibs/korge/view/FixedSizeContainer.kt 47.69% <0.00%> (ø)
...e/src/commonMain/kotlin/korlibs/korge/view/Mesh.kt 0.00% <0.00%> (ø)
... and 70 more

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz enabled auto-merge (squash) March 29, 2023 02:19
@soywiz soywiz merged commit 58dc331 into main Mar 29, 2023
9 checks passed
@soywiz soywiz deleted the cleanup/further.mutable.cleanups.and.mmatrix branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants