Three-argument document.open() #1925

Bruce0203 · 2023-10-05T17:20:59Z

corrected redirection in js

soywiz · 2023-10-05T18:18:59Z

korge/src/js/korlibs/render/DialogInterfaceJs.kt

@@ -11,7 +11,7 @@ import org.w3c.files.*
 class DialogInterfaceJs : DialogInterface {

    override suspend fun browse(url: URL) {
-        document.open(url.fullUrl)
+        document.open(url.fullUrl, "", "noopener=true")


Now that I notice. Shouldn't it be window.open?
https://developer.mozilla.org/en-US/docs/Web/API/Window/open

soywiz · 2023-10-10T13:47:08Z

Thanks! It seemed that the three argument version works also with document. While the single argument one works only with window. Not sure if a bug or not. In any case I will change to the window one.

Edit:

https://developer.mozilla.org/en-US/docs/Web/API/Document/open#three-argument_document.open

Three-argument document.open()
There is a lesser-known and little-used three-argument version of document.open(), which is an alias of Window.open() (see its page for full details).

This call, for example opens github.com in a new window, with its opener set to null:

Three-argument document.open()

13f200e

soywiz reviewed Oct 5, 2023

View reviewed changes

soywiz enabled auto-merge (squash) October 10, 2023 13:43

soywiz disabled auto-merge October 10, 2023 13:43

soywiz merged commit bb74ad1 into korlibs:main Oct 10, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Three-argument document.open() #1925

Three-argument document.open() #1925

Bruce0203 commented Oct 5, 2023

soywiz Oct 5, 2023 •

edited

soywiz commented Oct 10, 2023 •

edited

Three-argument document.open() #1925

Three-argument document.open() #1925

Conversation

Bruce0203 commented Oct 5, 2023

soywiz Oct 5, 2023 • edited

Choose a reason for hiding this comment

soywiz commented Oct 10, 2023 • edited

soywiz Oct 5, 2023 •

edited

soywiz commented Oct 10, 2023 •

edited