Allow providing pre-allocated BufferedImage for awtConvertImage #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferedImage itself has internal data buffers that it allocates everytime it's allocated, so this helps reduce memory usage and garbage collection if I'm calling this function often.
For context I have a personal project that grabs the image (a BufferedImage) from HDMI capture device, than sends it over to clients over my network so I can view my surveillance monitor in a different area. Each time I grab the image, I need to convert the image using awtConvertImage so that I can use Korge's Bitmap utils; notably QOI encoding to reduce the size of the data before sending it over the network. Currently, each time awtConvertImage is called, it creates a new BufferedImage.