Separated korlibs-logger from foundation to a new module #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soywiz
reviewed
Jan 16, 2024
Comment on lines
+13
to
+23
| dependencies { | ||
| commonMainApi(libs.kotlinx.coroutines.core) | ||
| commonMainApi(libs.kotlinx.atomicfu) | ||
| commonTestApi(libs.kotlinx.coroutines.test) | ||
| commonMainApi(libs.kotlinx.atomicfu) | ||
| commonTestApi(libs.kotlinx.coroutines.test) | ||
| commonMainApi(project(":korlibs-time")) | ||
| commonMainApi(project(":korlibs-crypto")) | ||
| commonMainApi(project(":korlibs-platform")) | ||
| commonMainApi(project(":korlibs-datastructure")) | ||
| } |
soywiz
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
We should check korlibs-logger dependencies. Likely we won't need anything else except for a lock or an atomic. We can duplicate it, or create korlibs-lock or korlibs-atomic.
I'm going to merge it, and make a PR removeing those that can be used as reference for other libraries if required.
soywiz
changed the title
holloszaboakos
added a commit
to holloszaboakos/korge
that referenced
this pull request
Jan 16, 2024
Separated logger from foundation to a new module (korlibs#2131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.