Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use thiserror to handle errors #39

Closed
edgarriba opened this issue Mar 9, 2024 · 5 comments
Closed

use thiserror to handle errors #39

edgarriba opened this issue Mar 9, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@edgarriba
Copy link
Member

edgarriba commented Mar 9, 2024

for now errors are handle with anyhow -- this is good at application level but ideally we should create custom error types for lib development.

ideally use https://github.com/dtolnay/thiserror

@edgarriba edgarriba added the enhancement New feature or request label Mar 9, 2024
@edgarriba edgarriba changed the title not use anyhow to handle errors use thiserror to handle errors Mar 17, 2024
@edgarriba edgarriba changed the title use thiserror to handle errors use thiserror to handle errors Mar 17, 2024
@vcode11
Copy link

vcode11 commented Apr 16, 2024

Hi @edgarriba I am interested in contributing to this project. How do I get started?

@edgarriba
Copy link
Member Author

@vcode11 thanks for the interest ! if you feel comfortable with Rust and thiserror feel free to go for it

@vcode11
Copy link

vcode11 commented Apr 17, 2024

I found your commit: d72fca8 this seems to solve the problem? Any particular reason why you didn't merge this? Anything that is missing here that you would like to have?

@edgarriba
Copy link
Member Author

edgarriba commented Apr 20, 2024

lack of time to finally land this but feel free to take that diff resume the task. The only thing i was a bit concerned is that i couldn't figure out properly how to chain all the original errors for the integrated library a propagate properly to the high level applications.

@edgarriba
Copy link
Member Author

implemented in main already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants