Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error pages #57

Closed
kashike opened this issue Jul 14, 2015 · 5 comments
Closed

Improve error pages #57

kashike opened this issue Jul 14, 2015 · 5 comments
Labels
enhancement errors ui
Milestone
Blizzard

Comments

@kashike
Copy link
Member

kashike commented Jul 14, 2015

http://symfony.com/doc/current/cookbook/controller/error_pages.html

Better error pages would be nice to have - some sort of image or something could be interesting.
@kashike kashike mentioned this issue Jul 14, 2015
Closed
@kashike
Copy link
Member Author

kashike commented Jul 14, 2015

ref #58

@lol768 lol768 modified the milestone: 1.1 (future deploy after 1.0) Jul 14, 2015
@kashike
Copy link
Member Author

kashike commented Jul 25, 2015

https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelHomeController.php
https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelLogController.php#L36
https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelStatController.php#L28
https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelGameController.php#L34
https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelCommandController.php#L29
https://github.com/korobi/Web/blob/master/src/Korobi/WebBundle/Controller/Generic/IRC/Channel/ChannelAIController.php#L23
etc

@lol768
Copy link
Member

lol768 commented Jul 25, 2015

I would suggest we create exceptions where possible (e.g. UnauthorisedChannelViewException or similar) and use http://symfony.com/doc/current/cookbook/controller/error_pages.html#working-with-the-kernel-exception-event to display relevant pages.

@lol768
Copy link
Member

lol768 commented Jul 25, 2015

ref #106

@kashike kashike mentioned this issue Aug 10, 2015
Closed
@kashike kashike added the errors label Aug 16, 2015
@jamierocks
Copy link
Contributor

When these pages are done, I will put them on the docs.

@kashike kashike closed this as completed Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement errors ui
Projects
None yet
Milestone
Blizzard
Development

No branches or pull requests
3 participants
@lol768 @jamierocks @kashike