Retina support

[yohanboniface]

Anyone for a review / test? :)

cc @nebulon42 @kent1D

[kent1D]

For the review, I don't think I can do something ;)

But I just tested

Here is a test non retina vs retina :

And here the retina vs retina :

On my retina screen, it loads directly @2x, on my non retina screen the normal scale.

I had nothing to do, is it right?

[kent1D]

Mmmh I has a bug maybe zooming too quickly

I had to close kosmtik and relaunch it to solve the problem

[kent1D]

Ok the bug appears in this use case.

2 screens for my computer, one in retina, the other not.

Charging the map on one of them.

Charging the map on the other.

The second one freeze.

Need to click on reload to reload the tiles

[nebulon42]

ATM I don't have a retina display available. How does it detect if it needs retina or not?
Is there the need for a separate map pool?

[yohanboniface]

How does it detect if it needs retina or not?

This is the browser that actually decides to ask for retina tiles (handled by Leaflet directly, see {r} parameter).

Is there the need for a separate map pool?

Yes, because the map itself needs a scale x2

[MattBlissett]

I'm only running this using the Docker setup in https://github.com/gravitystorm/openstreetmap-carto/, which I've changed:

-RUN npm install -g kosmtik
+RUN npm install -g git://github.com/kosmtik/kosmtik.git#retina

Switching between map pools, in my case by using "Responsive Design Mode" on Firefox developer tools and refreshing the page, causes kent1D's problem when going from 1→2, and when going from 2→1 a similar problem with tiles showing the wrong data:

I'd guess some variables are shared between the two pools, but shouldn't be.

[yohanboniface]

Thanks @MattBlissett for pointing me to a way to reproduce!

(Yeah, two months later, I know… ;) )