-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Javascript class syntax #319
Conversation
Thanks a lot for this work! Otherwise I'll have a look myself, but I'm a bit in a rush there days :( |
@yohanboniface Thanks for reviewing + merging so quickly :) Yes, definitely. It would be nice to also have the plugins up-to-date considering the code style. I will make some PRs in those plugin repos. After that, it would be nice to have NPM releases to let users (also see #309) without intimate Javascript/NodeJS knowledge install the package using the instructions in the readme. It would also be nice to have Travis build PRs / branches, such that feedback is available in Github PRs about the build status, before merging the PR. |
@yohanboniface I went through the entire list of plugins, and updated the (backend) code to the class syntax whereever possible. |
Fantastic work, thanks! |
Sure! Missing time to do it right away, I'll try next week, same for Travis :s |
Preview the diff with whitespace disabled! direct link
This PR
Cleans up the definition of backend classes massively, by using the Javascript
class
syntax. This allows:class A
instead of.prototype
constructor
andsuper
instead of static calls to parent prototypes.A extends B
instead ofutil.extends(...)