Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Healthcheck #121

Merged
merged 6 commits into from
Jun 24, 2023
Merged

[v2] Healthcheck #121

merged 6 commits into from
Jun 24, 2023

Conversation

SachdevJai
Copy link
Contributor

Using utils.Log functions to log errors and info

@SachdevJai SachdevJai changed the title V2 healthcheck [v2] healthcheck Jun 24, 2023
@SachdevJai SachdevJai changed the title [v2] healthcheck [v2] Healthcheck Jun 24, 2023
@harshkhandeparkar
Copy link
Member

Try installing golangci-lint locally and run it in the directory (and solve all the errors it reports). Alternatively, use the VSCode Go extension.

harshkhandeparkar
harshkhandeparkar requested changes Jun 24, 2023
View reviewed changes
controllers/healthcheck.go Outdated Show resolved Hide resolved
controllers/healthcheck.go Outdated Show resolved Hide resolved
controllers/healthcheck.go Show resolved Hide resolved
controllers/healthcheck.go Show resolved Hide resolved
harshkhandeparkar
harshkhandeparkar approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshkhandeparkar harshkhandeparkar merged commit 23705d7 into kossiitkgp:v2-dev Jun 24, 2023
@harshkhandeparkar harshkhandeparkar linked an issue Jun 24, 2023 that may be closed by this pull request
[v2] Use utils.Log* Functions in /healthcheck/* Controller #117
Closed
@SachdevJai SachdevJai deleted the v2-healthcheck branch June 24, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshkhandeparkar harshkhandeparkar harshkhandeparkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v2] Use utils.Log* Functions in /healthcheck/* Controller
2 participants
@SachdevJai @harshkhandeparkar