Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The isImmutable cache isn't always used #28

Open
GoogleCodeExporter opened this issue Mar 14, 2015 · 1 comment
Open

The isImmutable cache isn't always used #28

GoogleCodeExporter opened this issue Mar 14, 2015 · 1 comment
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

I noticed in Cloner.isImmutable only caches @Immutable if it finds one, not if 
it doesn't.

Should be enough with:
if (b != null) return b; // at the top
immutables.put(clz, Boolean.FALSE); //just before it returns false

Original issue reported on code.google.com by j...@mojang.com on 19 May 2014 at 8:23
@GoogleCodeExporter
Copy link
Author 

Yes this is a good point. Please have a look as I'm seeing my threads block on 
getDeclaredAnnotations() over and over again.

Original comment by m...@thebishops.org on 16 Sep 2014 at 10:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter