Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing ~/.eye directory causes eye to misbehave #67

Closed
tetherit opened this issue Jul 8, 2014 · 4 comments
Closed

Existing ~/.eye directory causes eye to misbehave #67

tetherit opened this issue Jul 8, 2014 · 4 comments
Labels
Milestone

Comments

@tetherit
Copy link

tetherit commented Jul 8, 2014

If the server was rebooted uncleanly, the existing ~/.eye directory causes eye to think processes are running when they are not, or to kill the wrong processes (based on PID?), or just not to start at all.

A quick fix is to rm -$ ~/.eye followed by eye load recorder.eye after a server reboot, but would be nice if eye could detect if it was rebooted?

I'm not sure how eye internals work, but maybe it can check for PID as well as process name or something before assuming a process is up when it is not?

@kostya
Copy link
Owner

kostya commented Jul 8, 2014

~/.eye not related to the process pids, you specify pid_file for every process.

Yes, i meet sometimes this problem too, when reboot and not call eye stop all && eye quit before, after reboot eye read pids from pid_files, and it can happen that there is already alive process with that pid (rare situation, but possible), so eye can kill that wrong process (or sometimes itself)
I also think about saving pid + name, for that situation, (god, bluepill, monit seems not doing this)

@kostya kostya mentioned this issue Jul 8, 2014
@kostya kostya added this to the 0.7 milestone Jul 8, 2014
@tetherit
Copy link
Author

tetherit commented Jul 8, 2014

This is why eye is so much better than those other ones :P - That would be awesome!

@tetherit
Copy link
Author

I'm not sure if this worked, after a reboot I can see this this last line in eye.log:

[2014-12-11 16:54:00 +0000] [recorder:52121f67c5399f42b400d4fc:recorder] process <9885> did not die after TERM, sending KILL

And then boom, Eye is dead - I think it still kills itself if the server is rebooted uncleanly :(

@kostya kostya added the bug label Jan 18, 2015
@kostya kostya closed this as completed Jan 31, 2015
@kostya
Copy link
Owner

kostya commented Jan 31, 2015

dup of #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant