New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ringbuffer & metadata in cudaCorrelator kernel #1188

Merged

dstndstn merged 13 commits into chord from dstn/chord/n2-ringbuf

Mar 22, 2024

Contributor

dstndstn commented Mar 19, 2024

assume the cudaCorrelator input is coming from a ring buffer
propagate metadata from the input to the correlation matrix output
fix testDataGen to produce output for more generator types (including random signed that we use in the test code)

dstndstn added 6 commits

March 19, 2024 15:53


          try modifying cudaCorrelator to use ring-buffered input array

20295aa


          testDataGen: make chordMetadata handling more general; set sample0_of…

1a1ce07

…fset


          fix yaml file for n2k testing

9af82c3


          cudaCorrelator: set output metadata (array shape); fix whitespace & d…

fab1cf3

…ocumentation


          mention ringbuffer in documentation

3ef7fb3


          clang-fromage

bff4c74

dstndstn requested a review from eschnett

March 19, 2024 20:24

eschnett reviewed

View reviewed changes

lib/cuda/cudaCorrelator.hpp Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

lib/cuda/cudaCorrelator.hpp Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

lib/cuda/cudaCorrelator.cpp Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

lib/cuda/cudaCorrelator.cpp Show resolved Hide resolved

eschnett reviewed

View reviewed changes

lib/stages/testDataGen.cpp Outdated Show resolved Hide resolved

eschnett requested changes

View reviewed changes

Contributor

eschnett left a comment

I suggested changes in comments.

dstndstn added 6 commits

March 19, 2024 21:59


          cudaCorrelator: check input metadata sizes, set output metadata to sp…

b44f259

…lit out dishes & polarizations


          add setter for name in chordMetadata, use in testDataGen

74813b9


          set std::locale globally (in kotekan.cpp)

9539e27


          print exception

5ccbd8c


          try globally setting the locale for fmt, for printing commas in large…

a3f224c

… numbers, like 123,456


          clang-fromage

89c683e

Contributor

eschnett commented Mar 20, 2024

Mmmm, "fromage"...

Contributor Author

dstndstn commented Mar 20, 2024

At first it was a typo but then I decided I liked it better!


          Merge branch 'chord' into dstn/chord/n2-ringbuf

57db978

dstndstn requested a review from eschnett

March 21, 2024 19:39

eschnett approved these changes

View reviewed changes

dstndstn merged commit 941f1f4 into chord

14 checks passed

dstndstn deleted the dstn/chord/n2-ringbuf branch

March 22, 2024 15:50

eschnett added a commit that referenced this pull request


          Merge branch 'chord' into eschnett/performance

0c0052b

* chord:
  Use ringbuffer & metadata in cudaCorrelator kernel (#1188)
  try to fix github action when merging back to chord (#1193)
  Grab changes from the review of #1152 (chord #1146) (#1167)

# Conflicts:
#	lib/stages/FEngine.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment