-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab changes from the review of #1152 (chord #1146) #1167
Conversation
…view: add various comments, and pull out FEngine.hpp header"
@dstndstn do you also want me to review this, or was there something you wanted Erik to check? |
Looks like this has gone a bit stale, let me resolve the conflicts and then yes, if you could review that would be great! |
Hi @andrerenard , if you wouldn't mind reviewing this, that would be great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with one comment to consider.
The test failures look really unrelated... |
I'm going to try rerunning them. We do have some tests that fail due to random number generator bad luck... But odd that all of them seemed to fail... |
The values seem to be very far off, so doesn't look like one of these random-sample things, maybe it's a real structural change we made by accident, but is it happening on the current head of the |
Oh yeah, some of those values are way out... Could the location settings somehow impact this? Seems really unlikely. I'm not seeing where this could have been added in the current head. The last big PR to go in seemed to pass everything except the boost tests. |
Best guess would be something updated in the docker container, since we've been making a few changes to that. @jbmertens Would you able to try and figure out what's happening here? It's in the N2 pipeline, and I think something you've looked at recently? |
Yeah, this does look like something that changed in Docker. The test passes on an older docker build from # 1152. I'll try to see exactly what changed. |
Okay, I think this is finally ready for review again!! |
// https://www.boost.org/doc/libs/1_75_0/libs/test/doc/html/boost_test/tests_organization/fixtures/global.html | ||
// Enable this in your test suite by adding: | ||
// BOOST_TEST_GLOBAL_FIXTURE(GlobalFixture_Locale); | ||
struct GlobalFixture_Locale { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, can we just remove this if we aren't going to use it anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, definitely could. I was setting the locale explicitly (to classic()) in kotekan.cpp, so I figured it would be good to at least have the mechanism to do the same in the tests, even if we're not using it. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable.
Cherry-pick 99c2ee9 from dstn/develop/chord-1146: "address Andre's review: add various comments, and pull out FEngine.hpp header"