Implement shouldNotThrow matchers #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that documentation is purposefully not updated, as this isn't a real feature. Following our conventions that Every should have a shouldNot, this is just a small fix. |
|
@sksamuel |
sksamuel
approved these changes
Jan 22, 2019
kotlintest-assertions/src/main/kotlin/io/kotlintest/AnyThrowableHandling.kt
Outdated
Show resolved
Hide resolved
This commit implements `shouldNotThrow`, `shouldNotThrowExactly` and `shouldNotThrowAny` matchers, with their `Unit` variations. Effectively, for the user, it doesn't make a difference on calling this and calling the code directly, but this may be better for communicating intent explicitly. These matchers won't let an uncaught failure to be silently caught. Any uncaught exception will still be propagated upwards, however, if it matches the `shouldThrow<T>` T parameter, it will be wrapped around an AssertionError (makes tests Yellow, not Red.). It's never necessary to use this construct. It would be the same as every java method being `void foo() throws no Exception`, and it usually doesn't make sense to. Fixes #205
LeoColman
force-pushed
the
feature/205-add-shouldNotThrow-matchers
branch
from
058834f
to
cd21fa1
Compare
|
Merging when this gets green. |
TAGC
reviewed
Jan 22, 2019
| * **Attention to assignment operations:** | ||
| * | ||
| * When doing an assignment to a variable, the code won't compile, because an assignment is not of type [Any], as required | ||
| * by [block]. If you need to test that an assignment doesn't throw a [Throwable], use [shouldNotThrowAnyUnit] or it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements
shouldNotThrow,shouldNotThrowExactlyandshouldNotThrowAnymatchers, with theirUnitvariations.Effectively, for the user, it doesn't make a difference on calling this and calling the code directly, but this may be better for communicating intent explicitly.
These matchers won't let an uncaught failure to be silently caught. Any uncaught exception will still be propagated upwards, however, if it matches the
shouldThrow<T>T parameter, it will be wrapped around an AssertionError (makes tests Yellow, not Red.).It's never necessary to use this construct. It would be the same as every java method being
void foo() throws no Exception, and it usually doesn't make sense to.Fixes #205