Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] Run unit tests against the latest kotlin-compiler builds #3540

Closed
IgnatBeresnev opened this issue Mar 19, 2024 · 0 comments · Fixed by #3552
Closed

[K2] Run unit tests against the latest kotlin-compiler builds #3540

IgnatBeresnev opened this issue Mar 19, 2024 · 0 comments · Fixed by #3552
Assignees
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone

Comments

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Mar 19, 2024

As part of the migration to K2 (#2888), Dokka is migrating to the new Analysis API which is still under active development. Updates of the Analysis API version sometimes break Dokka for various reasons (source compatibility, behavioral changes, etc). At the moment, we update the K2 compiler version manually, so we find out about these breaking changes quite late.

There should be a CI build (TC/GA) that runs Dokka's unit tests with the latest published -dev version of kotlin-compiler for K2 analysis (kotlin-compiler-k2 prop in versions.toml) once every couple of days.


Impl notes:

  • the TeamCity unit test build could be reused by adding a build step conditional on a parameter, and then add a scheduled trigger that sets this parameter to true or the desired version. This can help avoid the copy-paste in build configurations if TC is used.
  • it's fine to stick to the 2.0.0-dev-* pattern, we'll update it when the first builds of 2.1.x appear.
  • unit tests should be enough to find the overwhelming majority of incompatibilities - running lengthy integration tests might not be worth it in this particular case
@IgnatBeresnev IgnatBeresnev added tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life infrastructure Everything related to builds tools, CI configurations and project tooling labels Mar 19, 2024
@IgnatBeresnev IgnatBeresnev added this to the Dokka 2.0.0 milestone Mar 19, 2024
@IgnatBeresnev IgnatBeresnev added the topic: K2 Issues / PRs that are related to the K2 migration. See #2888 label Mar 21, 2024
@IgnatBeresnev IgnatBeresnev changed the title Run unit tests against the latest kotlin-compiler builds [K2] Run unit tests against the latest kotlin-compiler builds Mar 21, 2024
@vmishenev vmishenev self-assigned this Mar 27, 2024
@vmishenev vmishenev linked a pull request Mar 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants