-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ever print <ERROR CLASS> to the output #63
Comments
👍 Agree. |
Related to #79 |
Is this actual in flavor of #79 fix? |
Seems not a problem now, closing |
The problem still exists with the Dokka fatjar. |
In some positions, Dokka complete unable to determine the type, if something went wrong. @pvillela If such problem reproduces for you, it is possible result of missing dependencies, please clarify your case |
Thanks Simon. The functions in question had explicit signatures. The Dokka
Gradle plugin gave me the correct results while the Dokka fatjar gave me
several <ERROR CLASS> results, even though I used the same classpath and
sources in both cases.
…On Wed, Jan 30, 2019 at 8:53 AM Simon Ogorodnik ***@***.***> wrote:
In some positions, Dokka complete unable to determine the type, if
something went wrong.
It is unclear what behaviour should be in such cases
fun foo() = Bar() + Bar() // Bar is unresolved/undefined
@pvillela <https://github.com/pvillela> If such problem reproduces for
you, it is possible result of missing dependencies, please clarify your case
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfFvfes3AP8OWI5ElDmMK1q-0tpK-p2ks5vIaPrgaJpZM4Hv_0B>
.
|
@pvillela Check also that at time fatjar invoked all classpath jars exists. Basically Gradle plugin uses same fatjar so it seems strange for me |
Thanks, Simon. I have done what you recommended but the problem is still
there. I'm attaching 4 files:
1. Snippet from top-level gradle.kotlin.kts that shows that the Dokka
task and the Dokka fatjar are using exactly the same sources and classpath.
2. The script i'm using to run the fatjar
3. index-outline.html from running the Dokka task
4. index-outline.html from running the fatjar. This file is visibly
smaller than the one produced by the Dokka task.
Regards,
Paulo
…On Thu, Jan 31, 2019 at 5:47 AM Simon Ogorodnik ***@***.***> wrote:
@pvillela <https://github.com/pvillela> Check also that at time fatjar
invoked all classpath jars exists. Basically Gradle plugin uses same fatjar
so it seems strange for me
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAfFvROdQnASCglnafP_J95k4H89xocZks5vIsnDgaJpZM4Hv_0B>
.
|
It's either regression or the new issue, but as I said here: #503 (comment) we're hitting this hard |
It's much better to just pass unknown types through to the output as plain text rather than give the (entirely useless) type token to the reader.
The text was updated successfully, but these errors were encountered: