Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomicfu plugin adds common dependencies to platform modules #72

Closed
cy6erGn0m opened this issue Jun 27, 2019 · 2 comments
Closed

Atomicfu plugin adds common dependencies to platform modules #72

cy6erGn0m opened this issue Jun 27, 2019 · 2 comments
Assignees
@cy6erGn0m
Labels
bug

Comments

@cy6erGn0m
Copy link
Contributor

cy6erGn0m commented Jun 27, 2019 •
edited
Loading

Adding common dependency to a native module causes Gradle plugin to complain about it for every module. In ktor, it generates a huge number of warnings so one wouldn't be able to discover actual problems.

A compileOnly dependency is used in the Kotlin/Native target 'linuxX64':
Compilation: main

Dependencies:
org.jetbrains.kotlinx:atomicfu-common:0.12.9

Such dependencies are not applicable for Kotlin/Native, consider changing the dependency type to 'implementation' or 'api'.
@cy6erGn0m cy6erGn0m added the bug label Jun 27, 2019
@cy6erGn0m cy6erGn0m changed the title Atomicfu plugin adds common dependencies to common Atomicfu plugin adds common dependencies to platform modules Jun 27, 2019
@cy6erGn0m
Copy link
Contributor Author

A possible solution is to not add these dependencies or stop using compileOnly and switch to api or implementation.

@cy6erGn0m cy6erGn0m self-assigned this Jun 27, 2019
@mvicsokolova
Copy link
Collaborator

Related changes: #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cy6erGn0m cy6erGn0m

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cy6erGn0m @mvicsokolova