Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I am really confused, which dependency should be used? #63

Open
matkoniecz opened this issue Dec 14, 2021 · 6 comments
Open

I am really confused, which dependency should be used? #63

matkoniecz opened this issue Dec 14, 2021 · 6 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Dec 14, 2021

https://github.com/kotlinx/ast#using-with-gradle tells me

            dependencies {
                // please look at https://jitpack.io/#drieks/antlr-kotlin to find the latest version
                api("com.github.kotlinx.ast:grammar-kotlin-parser-antlr-kotlin:0123456789")

or

// please look at https://jitpack.io/#drieks/antlr-kotlin to find the latest version
implementation("com.github.kotlinx.ast:grammar-kotlin-parser-antlr-kotlin:0123456789")

https://jitpack.io/#drieks/antlr-kotlin tells me to use implementation 'com.github.drieks:antlr-kotlin:Tag'

https://jitpack.io/#drieks/antlr-kotlin/d4384e4d90 tells me to use implementation 'com.github.drieks.antlr-kotlin:antlr-kotlin-gradle-plugin:d4384e4d90'

Neither api("com.github.kotlinx.ast:grammar-kotlin-parser-antlr-kotlin:d4384e4d90") nor drieked version with api("com.github.drieks.ast:grammar-kotlin-parser-antlr-kotlin:d4384e4d90") works

And Android Studio requires me to use implementation("com.github.drieks.antlr-kotlin:antlr-kotlin-gradle-plugin:d4384e4d90") (a bit different syntax)

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Dec 14, 2021

And after doing either https://github.com/kotlinx/ast/blob/master/grammar-kotlin-parser-antlr-kotlin/src/jvmTest/kotlin/kotlinx/ast/example/ExampleMain.kt still fails with Unresolved reference: ast in import kotlinx.ast.common.AstSource

Is there somewhere full example project?

I really tried following readme, but it seems that I screwed something up.

@drieks
Copy link
Collaborator

drieks commented Dec 14, 2021

Oh, thank you for reporting this. https://github.com/kotlinx/ast is the "main" repository. https://github.com/drieks/antlr-kotlin/ is a fork of https://github.com/Strumenta/antlr-kotlin/ I'm using in kotlinx.ast to support kotlin.js and kotlin native. Currently, all my changes are merged into upstream, so drieks/antlr-kotlin is currently not required.

To make it complicated, https://github.com/drieks/ast is my "private" fork of kotlinx.ast.

I renamed some libraries some time ago, maybe I missed updating the documentation. Is it possible for you to create a repository containing the project where you are getting this? The Gradle files and maybe a copy of the ´Example-main.kt` should be enough.

@drieks
Copy link
Collaborator

drieks commented Dec 14, 2021

I tried to move the build from jitpack to github actions, but did not find time to finish it right now. I want to add normal version numbers and a github actions based build and to remove everything jitpack related because it seems to confuse users of kotlinx.ast.

But the readme should contain working examples, there must be a missing change that is required to get it working again.

@matkoniecz
Copy link
Contributor Author

I tried again ( https://github.com/matkoniecz/astmine ) :


But the readme should contain working examples, there must be a missing change that is required to get it working again.

Note that "Add the dependency to kotlinx.ast into your project:" is confusing for confused people like me. Looking at other code I have not found where exactly this snippet should be added.

If there would be chance for standalone working example - it would be highly appreciated.

Note: that is my first time when I tried making from scratch a gradle-powered project. It is likely that my failure is entirely caused by doing something the wrong way with gradle.

On retrying, if it will happen, I should use Groovy instead of Kotlin. Maybe instructions in repo are actually for Groovy? (though it mentions build.gradle.kts...)


api("com.github.kotlinx.ast:grammar-kotlin-parser-antlr-kotlin:14e92f2fa0") from readme got me

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':app:compileKotlin'
   > Could not resolve all files for configuration ':app:compileClasspath'.
      > Could not find com.github.kotlinx.ast:grammar-kotlin-parser-antlr-kotlin:14e92f2fa0.
        Searched in the following locations:
          - https://repo.maven.apache.org/maven2/com/github/kotlinx/ast/grammar-kotlin-parser-antlr-kotlin/14e92f2fa0/grammar-kotlin-parser-antlr-kotlin-14e92f2fa0.pom
          - https://jitpack.io/com/github/kotlinx/ast/grammar-kotlin-parser-antlr-kotlin/14e92f2fa0/grammar-kotlin-parser-antlr-kotlin-14e92f2fa0.pom
        Required by:
            project :app

https://jitpack.io/#drieks/antlr-kotlin suggested implementation("com.github.drieks:antlr-kotlin:Tag") (I tried with Kotlin-based build script), it resulted in

> Task :app:compileKotlin FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':app:compileKotlin'
   > Could not resolve all files for configuration ':app:compileClasspath'.
      > Could not find com.github.drieks:antlr-kotlin:Tag.
        Searched in the following locations:
          - https://repo.maven.apache.org/maven2/com/github/drieks/antlr-kotlin/Tag/antlr-kotlin-Tag.pom
          - https://jitpack.io/com/github/drieks/antlr-kotlin/Tag/antlr-kotlin-Tag.pom
        Required by:
            project :app

@matkoniecz
Copy link
Contributor Author

https://github.com/2bad2furious/kotlinx-ast-demo worked with minor tweaks (making gradlew executable, adding gradle folder)

@liuzhenhuanet
Copy link

dependencies {
implementation("com.github.kotlinx:ast:0.1.0")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants