Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo: [0, fps[ #23

Closed
liquidhelium opened this issue Jun 6, 2023 · 1 comment
Closed

Typo: [0, fps[ #23

liquidhelium opened this issue Jun 6, 2023 · 1 comment

Comments

@liquidhelium
Copy link

liquidhelium commented Jun 6, 2023 •
edited
Loading

https://github.com/negamartin/midly/blob/816cb2a585b4d5d1fd7aeb0cb35668f21dc00869/src/primitive.rs#L524

I believe it's a typo.
@kovaxis
Copy link
Owner

kovaxis commented Jun 6, 2023

No, it's exclusive range syntax. It's equivalent to [0, fps). I'm not sure why I used that syntax.
I've changed it to [0, fps-1] to make it clearer.

@kovaxis kovaxis closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kovaxis @liquidhelium