Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove linebreaks within pagragraph tags #186

Conversation

GusAntoniassi
Copy link

This merge request addresses #92 by adding the flag --drop-single-linebreak which when enabled will strip all \n characters within <p></p> tags.

Suggestions or changes to the flag name are welcome.

shouldn't</span>`

expected := `<p>This newline should be ignored</p>
<span>And this one
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually what is expected to be a result? Should not it be like this newline\tshould be ignored? As far as I see, the main idea was to remove only linebreaks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I'm aware, the goal to to avoid weird breaks in the confluence behavior; that involves flowing text in <p>, so \t should be removed as well

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like this feature as well but I agree that it should only replace linebreaks and not all space. The regex is incorrect.

What's the status of this? It hasn't had updates in a while so looks stale. Wasn't sure if I should put up another PR

@nyarly
Copy link
Contributor

nyarly commented Jul 26, 2023

I'd really like to see this feature land. @GusAntoniassi are you still working on this?

@nyarly nyarly mentioned this pull request Sep 6, 2023
@nyarly
Copy link
Contributor

nyarly commented Sep 7, 2023

I think this can be closed in favor of #351 @mrueg

@mrueg
Copy link
Collaborator

mrueg commented Oct 20, 2023

@nyarly thanks. Closing this as per #351

@mrueg mrueg closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants