Adding linebreak stripping #351
Conversation
| } | ||
| } | ||
|
|
||
| func TestCompileMarkdownDropH1(t *testing.T) { |
There was a problem hiding this comment.
Also added tests for DropH1 - I can't swear to their accuracy, but they look right
| } | ||
| } | ||
| } else { | ||
| _ = w.WriteByte(byte(r.softBreak)) |
There was a problem hiding this comment.
This is effectively taken directly from goldmark (like the other renderers), with this exception.
There was a problem hiding this comment.
Can you add a reference where you took it from as a comment?
| <p>two-2</p> | ||
| <p>three-1</p> | ||
| <p>three-2</p> | ||
| <p>space-1 space-2</p> |
| </ul> | ||
| </ac:rich-text-body></ac:structured-macro> | ||
| <ul> | ||
| <li>Regular list that runs long</li> |
There was a problem hiding this comment.
This is the thing that cannot be (easily) got by e.g. a sed script.
pkg/mark/renderer/text.go
Outdated
| import ( | ||
| "unicode/utf8" | ||
|
|
||
| //"github.com/kovetskiy/mark/pkg/mark/stdlib" |
There was a problem hiding this comment.
Can you remove the import here if you don't need it?
|
Thanks for the contribution! I've added a couple of comments to it. |
| @@ -63,6 +63,13 @@ var flags = []cli.Flag{ | |||
| Usage: "don't include the first H1 heading in Confluence output.", | |||
| EnvVars: []string{"MARK_H1_DROP"}, | |||
| }), | |||
| altsrc.NewBoolFlag(&cli.BoolFlag{ | |||
| Name: "strip-linebreaks", | |||
| Value: false, | |||
There was a problem hiding this comment.
Should we enable it by default?
There was a problem hiding this comment.
It would be a change to the output, which is why I set it disabled by default. If it were me, I'd enable by default on the next major release, and remove the option on the release after that.
There was a problem hiding this comment.
Okay, makes sense, I'll switch it on once we release mark-10.x
| reg.Register(ast.KindText, r.renderText) | ||
| } | ||
|
|
||
| func (r *ConfluenceTextRenderer) renderText(w util.BufWriter, source []byte, node ast.Node, entering bool) (ast.WalkStatus, error) { |
There was a problem hiding this comment.
Maybe add a comment on top why this is needed and what it does instead of the default text renderer from goldmark
|
I've updated the PR in response to comments. |
Adds
--strip-newlineswhich collapses single newlines into a space - effectively what would happen during normal HTML rendering. This is to address Confluence's behavior, which is to insert a<br>.Closes #92