Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL-D Not Recongized in TinTin++ #4354

Closed
prg318 opened this issue Dec 13, 2021 · 3 comments
Closed

CTRL-D Not Recongized in TinTin++ #4354

prg318 opened this issue Dec 13, 2021 · 3 comments
Labels

Comments

@prg318
Copy link

prg318 commented Dec 13, 2021

Describe the bug
Background information: TinTIn++ is a very popular cross-platform MUD client. Normally, CTRL-D on an empty line is used to quit tintin++ (or alternatively, the #end command). I've tested that this works with xterm, urxvt, and konsole. When trying to do this with kitty, the following sequence is displayed when pressing CTRL-D instead of quitting the client: "\e[100;133u". Here is an example of the terminal output when running tintin++ with kitty:

 $ echo $TERM       
xterm-kitty
 $ tt++

                Legends of Kallisti - http://www.KallistiMUD.com                

One of the longest running, most feature rich MUDs in the world with decades    
of development. Kallisti boasts a massive original world, great atmosphere of   
players, excellent combat system including group formations, ranged combat,     
optional PK and arena PvP, extensive character customization, player lineages,  
clans, customizable player houses, item crafting, extensively customizable UI,  
Mud Sound Protocol, extensive blind player support, MSDP, and so much more.     
                                                                                
This is an amazing game that you could literally play for a decade and still    
discover more - you won't be disappointed!                                      

To connect to Legends of Kallisti enter: #session LoK kallistimud.com 4000      

      ####################################################################
      #                                                                  #
      #                    T I N T I N + +   2.02.12                     #
      #                                                                  #
      #      Code by Peter Unold, Bill Reis, and Igor van den Hoven      #
      #                                                                  #
      ####################################################################

\e[100;133u
\e[100;133u
\e[100;133u

This seems to occur with "xterm-kitty" terminfo as well as just normal "xterm" terminfo

To Reproduce
Steps to reproduce the behavior:

  1. Use kitty as a terminal emulator
  2. Launch tintin++
  3. Attempt to quit with CTRL-D
  4. See that tintin++ does not quit, but instead prints "\e[100;133u"

Environment details

kitty 0.23.1 created by Kovid Goyal
Linux g15 5.15.7-arch1-1 #1 SMP PREEMPT Wed, 08 Dec 2021 14:33:16 +0000 x86_64
Arch Linux \r (\l)
LSB_VERSION=1.4
DISTRIB_ID=Arch
DISTRIB_RELEASE=rolling
DISTRIB_DESCRIPTION="Arch Linux"
Running under:X11
Loaded config files:
  /home/lukas/.config/kitty/kitty.conf

Config options different from defaults:
background_opacity         0.85
close_on_child_death       True
dynamic_background_opacity True
enable_audio_bell          False
font_family                Hack
font_size                  12.0
initial_window_height      (600, 'px')
initial_window_width       (940, 'px')
remember_window_size       False
Added mouse actions:
	 ctrl+b1 repeat ungrabbed KeyAction('mouse_click_url')
	 ctrl+b1 repeat grabbed KeyAction('mouse_click_url')
	 ctrl+b1 press grabbed KeyAction('discard_event')
Added shortcuts:
	shift+super+w KeyAction('close_os_window')
Changed shortcuts:
	shift+ctrl+e KeyAction('kitten', ('hints',))

Additional context
This problem occurs with an empty kitty configuration as well as an empty tintin++ configuration. No special configuration is required to reproduce this issue.

Let me know if there is anything else I can do to assist in resolving this issue. I realize that tintin++ isn't a mission critical application, but if kitty is behaving differently from most other terminals then perhaps there is something worth looking into here. Thanks!

@prg318 prg318 added the bug label Dec 13, 2021
@page-down
Copy link
Contributor

Cannot be reproduced in kitty nightly releases, Ubuntu Latest LTS, tintin++ Latest.

To me it seems you need the correct terminfo.

https://sw.kovidgoyal.net/kitty/faq/

@prg318
Copy link
Author

prg318 commented Dec 14, 2021

I can confirm that using the latest git sources fixes this issue for me, but the issue is still present on v0.23.1.

I can also confirm that I absolutely have the correct terminfo (xterm-kitty) and that it has been installed properly; so while I also thought to check the terminfo before posting this, it doesn't seem to be the case here.

If the issue has been fixed in the latest git master branch, then it's probably OK to close this since it should be fixed in the next kitty release.

Thanks all

(edit): just to add, it looks like the stdout from the kitty process when running tt++ in kitty is also different from the latest release and the latest git sources, which may be a hint to the change in behavior:

latest git kitty output running tt++:

[347 21:06:10.165558] [PARSE ERROR] The application is trying to use XTerm's modifyOtherKeys. This is superseded by the kitty keyboard protocol: https://sw.kovidgoyal.net/kitty/keyboard-protocol/ the application should be updated to use that
[347 21:06:10.165586] [PARSE ERROR] Unsupported screen mode:  7787 (private)
[347 21:06:10.608716] [PARSE ERROR] Unknown CSI t sequence with start and end modifiers: '' '#', 1 parameters and first parameter: 0
[347 21:06:10.608750] [PARSE ERROR] Unsupported screen mode:  7787 (private)

0.23.1 kitty output running tt++:

[347 21:06:29.901256] [PARSE ERROR] Unsupported screen mode:  1016 (private)
[347 21:06:29.901281] [PARSE ERROR] Unsupported screen mode:  7787 (private)

@page-down
Copy link
Contributor

XTMODKEYS will no longer be supported in future releases.

#4075

The author of tintin has reported a similar problem here and has also advised that the program needs to be updated to support the kitty keyboard protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants