-
-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kitty graphics protocol: Incorrect image deletion behaviour #5081
Comments
I cannot replicate with:: icat logo/kitty.png && python -c "print('\n' * 120)" && printf '\e_Ga=d,d=c\e\' |
Thanks so much... I tried with I'll look into my implementation (and probably compare with |
After some further testing, it turns out
does have the same issue. |
Does not reproduce for me with icat --scale-up logo/kitty.png && python -c "print('\n' * 120)" && printf '\e_Ga=d,d=c\e' |
The same also occurred here with So, I realized Then, I decided to try |
Oh, wow! |
Even outrageous values (though not large enough to wrap around) of |
Thanks 👍 I'll build from source and check it out as soon as I can. |
Please do as I am travelling at the moment so I dont have the time to |
Sorry it took some days... All that trouble caused by some fixed-width integers and type casting 🥲. Thanks so much! |
By the way, here (AnonymouX47/term-image#39) is what I was working on when I discovered the bug. I planned to use If I encounter any other difficulties/issues, I'll reach out. |
You're welcome and thanks for finding the bug. Feel free to ping me if |
Oh and if and when you release your kitty graphics protocol support feel free to ping me or send a PR to add a reference to your project in https://sw.kovidgoyal.net/kitty/graphics-protocol/ |
Ok, will do so. |
Hello! 😃 I've just released a new version of my project Thanks ❤️ EDIT: Just sent a PR. |
Describe the bug
The delete action
a=d
withd=c|C
,d=x|X
,d=y|Y
,d=p|P
,d=q|Q
all perform what they're specified to do but beyond that, they also delete all images off the screen i.e images that have been scrolled past the top of the window (not the text area i.e including the window title bar if in the topmost pane).d=x|X
might be excluded though, since the scrolled-off image might technically intersect with the column but I expect it to be limited to on-screen images.This only affect off-screen images.
To Reproduce
Steps to reproduce the behavior:
a=T
.<ESC>_Ga=d,d=c<ESC>\
d=c
withd=y,y=N
(where N is an integer), etc...Screenshots
Environment details
Additional context
Same results with
--config NONE
and outsideIPython
(i.e directly from the shell).The text was updated successfully, but these errors were encountered: