Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't die return m a? #178

Closed
ilyakooo0 opened this issue Aug 9, 2019 · 2 comments · Fixed by #179
Closed

Why doesn't die return m a? #178

ilyakooo0 opened this issue Aug 9, 2019 · 2 comments · Fixed by #179
Labels
enhancement New feature or request question Further information is requested refactoring

Comments

@ilyakooo0
Copy link
Contributor

ilyakooo0 commented Aug 9, 2019

Is there a specific reason why die in Relude returns an m () instead of m a like die from System.Exit, which is actually used in the implementation?

@chshersh chshersh added enhancement New feature or request question Further information is requested refactoring labels Aug 13, 2019
@chshersh chshersh added this to the v0.6.0.0: Refinement milestone Aug 13, 2019
@chshersh
Copy link
Contributor

@ilyakooo0 There is no particular reason. I don't know why die returns m (), probably an oversight. I agree that m a is better because it's more consistent with base and more convenient. Would you like to open a PR with the fix?

@ilyakooo0
Copy link
Contributor Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants