Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array of tables #13

Closed
chshersh opened this issue Apr 4, 2018 · 10 comments
Closed

Support array of tables #13

chshersh opened this issue Apr 4, 2018 · 10 comments
Assignees
Labels
ast Type of TOML help wanted Extra attention is needed parser Everything related to `Text -> Toml` pretty-printer Everything related to `Toml -> Text`

Comments

@chshersh
Copy link
Contributor

chshersh commented Apr 4, 2018

This is important issue since array of tables is probably the only reasonable way to specify data structures like List and Map in TOML. Though, it's hard to support them...

@chshersh chshersh added ast Type of TOML parser Everything related to `Text -> Toml` pretty-printer Everything related to `Toml -> Text` labels Apr 4, 2018
@chshersh chshersh added this to the v1.0.0: Public release milestone May 22, 2018
@vrom911 vrom911 added help wanted Extra attention is needed Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 30, 2018
@goosedb
Copy link

goosedb commented Oct 6, 2018

If you need arrays and tables I'll take this issue.

@chshersh
Copy link
Contributor Author

chshersh commented Oct 6, 2018

@goosedb Arrays and tables are already supported by the tomland library 🙂 This issue is about Array of tables.

@goosedb
Copy link

goosedb commented Oct 6, 2018

Oh, I see. I'll try.

@chshersh
Copy link
Contributor Author

chshersh commented Oct 6, 2018

@goosedb Note, that you should uncomment and use this field of TOML data type:

Also, be aware that the refactoring of the Toml.Parser module by @MorrisLaw is coming and it's probably a good idea to wait some time to avoid huge conflicts 🙂

@goosedb
Copy link

goosedb commented Oct 12, 2018

@chshersh So, when will the refactoring be completed?

@chshersh
Copy link
Contributor Author

@goosedb I think, only @MorrisLaw can answer...

@chshersh
Copy link
Contributor Author

@goosedb On the other hand, I think, you can start to work in this. I will help with resolving conflicts if anything happens 👍

@gahag
Copy link
Contributor

gahag commented Oct 22, 2018

I've sent a pull request with the refactoring.

@jiegillet
Copy link
Collaborator

I might start working on this one if it's OK.

@jiegillet
Copy link
Collaborator

I have a version that seems to be working (I need to run more tests though), but it doesn't include the new parsers in #121 so I'll wait for that one to be merged to proceed.

@chshersh chshersh removed the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 7, 2018
@chshersh chshersh self-assigned this Jan 4, 2019
@chshersh chshersh pinned this issue Jan 4, 2019
@chshersh chshersh unpinned this issue Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Type of TOML help wanted Extra attention is needed parser Everything related to `Text -> Toml` pretty-printer Everything related to `Toml -> Text`
Projects
None yet
Development

No branches or pull requests

5 participants