Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_PYTHON_3=OFF doesn't work #76

Closed
yurivict opened this issue Mar 31, 2018 · 5 comments
Closed

USE_PYTHON_3=OFF doesn't work #76

yurivict opened this issue Mar 31, 2018 · 5 comments
Labels
enhancement Not strictly a bug but more of a feature enhancement request

Comments

@yurivict
Copy link
Contributor

yurivict commented Mar 31, 2018

It still linked to python2. I have both installed on FreeBSD.
There can be many python versions installed. You should have a cmake variable which accepts the python executable, and then you should read everything else from it.

@kpeeters
Copy link
Owner

Giving the status of python2, I am not going to spend more energy into building against that. Should probably get rid of USE_PYTHON_3 altogether.

@yurivict
Copy link
Contributor Author

There still can be a problem in selection of python-3.5 vs. python-3.6 for example.

@kpeeters
Copy link
Owner

It's something worth doing at some point, but requires careful testing. At the moment I am happy that the lot builds on all the various platforms; I would like to avoid introducing changes which are likely to break the build on one of them.

@yurivict
Copy link
Contributor Author

I am not saying that this is urgent, it's rather something to keep in mind.
Once you have a patch I will be happy to test it. FreeBSD might be the best platform to test it because one can easily install all possible python versions at the same time.
Currently, this is a source of potential incorrectness in the FreeBSD port.

@kpeeters kpeeters added the enhancement Not strictly a bug but more of a feature enhancement request label Jan 14, 2022
@kpeeters
Copy link
Owner

Python 2.x is no longer supported (hasn't been for some time) so I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not strictly a bug but more of a feature enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants