-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set-project-id
relies on apply-setter to edit project
#2690
Comments
set-project-id
cannot detect setters in Kptfile set-project-id
relies on apply-setter to edit project
Was this a regression? It seems like he original purpose of |
@morgante Correct. Current I see the rationale behind |
I am not supportive of removing I'm still not sure I follow the issue. If you don't use setters at all, does |
"remove As a workaround before a setter free solution, I'm fine with the function to rely on apply-setter and modify the Kptfile file. But it should not be treated as curated and should not use misleading names. |
It was never intended to be "imperative-only." It sounds like the original implementation was done incorrectly, as go/set-project-id was meant to be usable in both imperative and declarative workflows. I have no interest in a separate "imperative-only" function. Please focus on updating the existing function to match the spec I provided. |
As the name shows,
set-project-id
should be safely used as a declarative function in Kptfile. However, it is only used as an imperative function that changes Kptfile only:Running
kpt fn eval --image gcr.io/kpt-fn/set-project-id
adds a newapply-setter
function to Kptfile. See README.The
set-project-id
cannot be used in Kptfile directly. errorsinclude-meta-resources
is not supported inkpt fn render
. Even if supported, it won't edit the actual resource files but only change Kptfile file.Under the hood,
set-project-id
relies onapply-setter
to do the real work. This is an anti-pattern of relying onset-project-id
and other specific functions to build a setter free configurations.The text was updated successfully, but these errors were encountered: