Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove msprime mutations in the recaptiation region #1

Closed
petrelharp opened this issue Dec 5, 2019 · 3 comments
Closed

Don't remove msprime mutations in the recaptiation region #1

petrelharp opened this issue Dec 5, 2019 · 3 comments
Assignees

Comments

@petrelharp
Copy link
Collaborator

so if you keep the initial slim generation in the tree sequence
ie don't simplify
then you can always tell which muts happened in the slim period versus in the recapitation period
so you should only thin mutations in the slim period
so only mutations for which the parent of the edge on which the mutation occurred lived since the start > of the slim period
can efficiently get that out of the tables

@mufernando
Copy link
Member

Can you help me craft a solution to this? The existing code to remove the mutations is in greatapes_sims/overlay.py

@mufernando
Copy link
Member

mufernando commented Jan 8, 2020

Fixed with commit fff9f61

Pretty sure this does the right thing, but would be good to have a code review (@petrelharp ?)

@mufernando mufernando self-assigned this Jan 8, 2020
@petrelharp
Copy link
Collaborator Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants