Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import from lutris #233

Closed
TungstnBallon opened this issue Feb 16, 2024 · 2 comments
Closed

Cannot import from lutris #233

TungstnBallon opened this issue Feb 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@TungstnBallon
Copy link

Describe the bug
Cartridges does not import games installed through lutris.

To Reproduce
Steps to reproduce the behavior:

  1. Install Lutris via pacman: sudo pacman -S lutris
  2. Add a game to Lutris
  3. launch Cartridges
  4. Steam games are imported, Lutris games aren't

Expected behavior
I expect games from lutris to appear in the cartridges library

Screenshots
These are the import settings for lutris
lutris_imports

Logs
From the console:

❯ hu.kramo.Cartridges

(process:2): Gtk-WARNING **: 09:30:54.733: Locale not supported by C library.
	Using the fallback 'C' locale.
Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/cartridges/importer/source.py", line 95, in __iter__
    location.resolve()
  File "/app/lib/python3.11/site-packages/cartridges/importer/location.py", line 93, in resolve
    raise UnresolvableLocationError(self.optional)
cartridges.importer.location.UnresolvableLocationError: False

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/app/lib/python3.11/site-packages/cartridges/importer/importer.py", line 134, in <lambda>
    lambda _task, _obj, _data, _cancellable, src=source: self.source_task_thread_func(
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/cartridges/importer/importer.py", line 174, in source_task_thread_func
    iterator = iter(source)
               ^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/cartridges/importer/source.py", line 98, in __iter__
    raise UnresolvableLocationError from error
TypeError: UnresolvableLocationError.__init__() missing 1 required positional argument: 'optional'
root INFO - Scanning source steam
root INFO - Import done

From debugging information:

30:54 - DEBUG: Starting hu.kramo.Cartridges v2.7.2 (release)
30:54 - DEBUG: Python version: 3.11.7 (main, Nov 10 2011, 15:00:00) [GCC 13.2.0]
30:54 - DEBUG: Flatpak version: Flatpak 1.15.6
30:54 - DEBUG: Platform: Linux-6.7.4-arch1-1-x86_64-with-glibc2.38
30:54 - DEBUG: 	System: Linux
30:54 - DEBUG: 	Node: archtower
30:54 - DEBUG: 	Release: 6.7.4-arch1-1
30:54 - DEBUG: 	Version: #1 SMP PREEMPT_DYNAMIC Mon, 05 Feb 2024 22:07:49 +0000
30:54 - DEBUG: 	Machine: x86_64
30:54 - DEBUG: 	Processor: 
30:54 - DEBUG: ─────────────────────────────────────
30:54 - DEBUG: New store game Steam (Runtime) (desktop_steam)
30:54 - DEBUG: DisplayManager done for desktop_steam
30:54 - DEBUG: New store game Terra Nil (steam_1593030)
30:54 - DEBUG: DisplayManager done for steam_1593030
30:54 - DEBUG: New store game Steamworks Common Redistributables (steam_228980)
30:54 - DEBUG: DisplayManager done for steam_228980
31:02 - DEBUG: Importing games from source lutris
31:02 - DEBUG: Importing games from source steam
31:02 - DEBUG: Resolved value for schema key lutris-location: /home/user/.local/share/lutris
31:02 - DEBUG: Resolved value for schema key steam-location: /home/user/.steam/steam
31:02 - INFO: Scanning source steam
31:02 - DEBUG: Skipped /home/user/.local/share/Steam/steamapps/appmanifest_1628350.acf: not installed
31:02 - DEBUG: Duplicate store game Steamworks Common Redistributables (steam_228980)
31:02 - DEBUG: Skipped /home/user/.local/share/Steam/steamapps/appmanifest_292030.acf: not installed
31:02 - DEBUG: Duplicate store game Terra Nil (steam_1593030)
31:02 - DEBUG: Skipped /home/user/.local/share/Steam/steamapps/appmanifest_1493710.acf: not installed
31:02 - DEBUG: Import done for source lutris
31:02 - DEBUG: Import done for source steam
31:02 - INFO: Import done
31:09 - DEBUG: Resolved value for schema key flatpak-system-location: /var/lib/flatpak
31:09 - DEBUG: Resolved value for schema key lutris-location: /home/user/.local/share/lutris
31:09 - DEBUG: Resolved value for schema key steam-location: /home/user/.steam/steam

System (please complete the following information):

  • OS: Archlinux
  • Installation method: Flatpak
  • Cartridges version: 2.7.2

Additional context

  • I tried setting the Lutris cache location to ~/.cache/lutris. but Cartridges reports this as an invalid directory. Adding the directory permissions to Cartridges through Flatseal does not resolve this.
  • I did also install the Lutris Flatpak but i don't know how to transfer my Lutris games over.
@TungstnBallon TungstnBallon added the bug Something isn't working label Feb 16, 2024
@kra-mo
Copy link
Owner

kra-mo commented Feb 17, 2024

Is the issue resolved in this build?

https://github.com/kra-mo/cartridges/actions/runs/7941902535

@kra-mo
Copy link
Owner

kra-mo commented Feb 17, 2024

Ah nevermind, Lutris seems to have changed where they store game covers. I'll push a fix.

@kra-mo kra-mo closed this as completed in 8efce82 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants