Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SI refactor breaks build #96

Closed
jlowellwofford opened this issue Jun 15, 2019 · 1 comment · Fixed by #123
Closed

SI refactor breaks build #96

jlowellwofford opened this issue Jun 15, 2019 · 1 comment · Fixed by #123
Labels
bug Something isn't working

Comments

@jlowellwofford
Copy link
Contributor

2019/06/15 08:10:24 Run: go build -o main includes.go main.go pprof.go

command-line-arguments

./main.go:129:33: cannot use k (type *core.Kraken) as type lib.ServiceInstance in argument to core.Registry.RegisterMutations:
*core.Kraken does not implement lib.ServiceInstance (missing Cmd method)
./main.go:130:36: cannot use k (type *core.Kraken) as type lib.ServiceInstance in argument to core.Registry.RegisterDiscoverable:
*core.Kraken does not implement lib.ServiceInstance (missing Cmd method)
@jlowellwofford jlowellwofford added the bug Something isn't working label Jun 15, 2019
@jlowellwofford jlowellwofford mentioned this issue Jun 27, 2019
Merged
@jlowellwofford
Copy link
Contributor Author

The PR was reverted until the details of this bug can be worked out.

@jlowellwofford jlowellwofford mentioned this issue Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mutations & Discoverables should belong to ServiceInstances (not Modules) jlowellwofford/kraken
1 participant
@jlowellwofford