Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TypeScript typings #89

Closed
mstuart opened this issue Oct 2, 2020 · 13 comments
Closed

Create TypeScript typings #89

mstuart opened this issue Oct 2, 2020 · 13 comments

Comments

@mstuart
Copy link
Contributor

mstuart commented Oct 2, 2020

See #31 for more information.

This project isn't written in TypeScript, but many TypeScript users would like to use published typings. For this issue, create TypeScript typings that cover the exported functions, and contribute it back to DefinitelyTyped!

This issue is great for someone who wants to learn more about TypeScript!

@JohnnyUrosevic
Copy link

Hi I would to work on this to learn a little bit about TypeScript :)

@mstuart
Copy link
Contributor Author

mstuart commented Oct 7, 2020

Hi @JohnnyUrosevic! Still want to take this? Just checking in, so that we can give others a chance if you're busy. Thanks!

@JohnnyUrosevic
Copy link

Hi I still want to work on this, but I'm just a Typescript noob so I'm not exactly sure where to start

@Cijin
Copy link

Cijin commented Oct 8, 2020

Hi, if this issue is still open. I'd like to take this up.

@JohnnyUrosevic
Copy link

go ahead and take it @Cijin

@Cijin
Copy link

Cijin commented Oct 8, 2020

Thanks, on it 👍

@songz songz mentioned this issue Oct 9, 2020
@songz
Copy link

songz commented Oct 9, 2020

Starting point, from #31 that someone did: https://gist.github.com/NinoScript/6478d60282816393ca75c99937a9f6e5

@mstuart
Copy link
Contributor Author

mstuart commented Oct 13, 2020

Happy hacking @Cijin !

@Cijin
Copy link

Cijin commented Oct 14, 2020

@mstuart PR created at definitely typed. The owners of the package will be notified automatically by the typescript bot.
Thank you @NinoScript for your docs, I have tagged you as an author too.

Here is the link to the PR

@Cijin
Copy link

Cijin commented Oct 15, 2020

Hey, the PR got merged 😃 . The npm package is available here:
@types/post-robot

@mstuart
Copy link
Contributor Author

mstuart commented Oct 21, 2020

Sweet!! Thanks @Cijin!

@songz
Copy link

songz commented Oct 30, 2020

@mstuart should this issue be closed? Seems like all the functions that postrobot exposes are closed.

@mstuart
Copy link
Contributor Author

mstuart commented Nov 10, 2020

I think so! Thanks for keeping an eye on that @songz!

@mstuart mstuart closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants