Fixes to bin dump #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though I think there should be transitition methods for the bin stuff, and those are existing now should be renamed with apcu_ prefix, like original int apc_bin_dumpfile ( array $files , array $user_vars , string $filename [, int $flags = 0 [, resource $context ]] ) should be an alias which should just ignore the first arg, which should be equivalent to int apcu_bin_dumpfile ( array $user_vars | NULL , string $filename [, int $flags = 0 [, resource $context ]] ) The same i'd say should be done for all the other functions where applicable, for APC compatibility right out of the box. |
CrystSw
added a commit
to CrystSw/apcu
that referenced
this pull request
Jan 14, 2024
# This is the 1st commit message: implement history list # This is the commit message krakjoe#2: add assert # This is the commit message krakjoe#3: rename variable # This is the commit message krakjoe#4: implementation of eviction logic # This is the commit message krakjoe#5: add comment # This is the commit message krakjoe#6: change define # This is the commit message krakjoe#7: added info # This is the commit message krakjoe#8: remove apc_cache_wlocked_add_history_oldest # This is the commit message krakjoe#9: rename function # This is the commit message krakjoe#10: update info # This is the commit message krakjoe#11: update comment # This is the commit message krakjoe#12: fixed loop (cause an infinite loop) # This is the commit message krakjoe#13: add memo # This is the commit message krakjoe#14: change cleaning timing # This is the commit message krakjoe#15: use macros # This is the commit message krakjoe#16: fixed size # This is the commit message krakjoe#17: update the history in the update process # This is the commit message krakjoe#18: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.