Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set default http timeouts #723

Closed
wants to merge 2 commits into from
Closed

feat: set default http timeouts #723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb3fac
set default http timeouts
ankurk91 Jul 28, 2022
588a70f
Update doc block
ankurk91 Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Firebase/Http/HttpClientOptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ final class HttpClientOptions
/**
* The amount of seconds to wait while connecting to a server.
*
* Defaults to indefinitely.
* Defaults to 15 seconds.
*/
private ?float $connectTimeout = null;
private ?float $connectTimeout = 15;

/**
* The amount of seconds to wait while reading a streamed body.
Expand All @@ -25,9 +25,9 @@ final class HttpClientOptions
/**
* The amount of seconds to wait for a full request (connect + transfer + read) to complete.
*
* Defaults to indefinitely.
* Defaults to 30 seconds.
*/
private ?float $timeout = null;
private ?float $timeout = 30;

/**
* The proxy that all requests should be passed through.
Expand Down