feat: set default http timeouts #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x #723 +/- ##
=============================================
- Coverage 72.89% 56.21% -16.68%
Complexity 1525 1525
=============================================
Files 151 151
Lines 4221 4221
=============================================
- Hits 3077 2373 -704
- Misses 1144 1848 +704 |
|
Merged with 0c10881, thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref kreait/laravel-firebase#146
Lets set sensible default timeouts to HTTP client.
I have taken these values from Laravel framework HTTP client.
This should not be a breaking change to existing users since firebase server is not going to wait for us indefinitely.